fix: prod CI가 임시 DB 컨테이너를 쓰도록 수정 (테스트 실행 포함) - #219
Merged
Conversation
-x test로 테스트를 건너뛰고 있었고, 건너뛰지 않더라도 실제 prod DB에 의존하는 구조였음 (dev-ci에서 이미 겪은 것과 동일한 문제). dev-ci와 동일하게 CI 안에 임시 postgres/redis 컨테이너를 띄우고 그쪽을 보게 수정.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 배경
-x test로 테스트를 건너뛰고 있었고, 건너뛰지 않더라도 실제 원격 prod DB에 의존하는 구조였음. dev-ci에서 동일한 문제를 이미 겪고 고쳤던 것과 같은 패턴.변경 사항
.github/workflows/prod-ci.yml-x test제거, CI 안에 임시 postgres/redis 컨테이너를 띄우고 그쪽을 바라보게 datasource/redis 접속 정보를 환경변수로 오버라이드영향 범위
Test Plan
🤖 Generated with Claude Code